Reject boolean PyTorch normal parameters#3237
Merged
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
random.normalvalidation for booleanlocandscaleparameters before dispatching to scalar or tensor sampling pathsBug fixed
The PyTorch backend accepted boolean
loc/scalevalues forrandom.normal, silently treating them as numeric 0/1. Other random parameter validators already reject booleans as non-numeric control values, so this was an inconsistent and error-prone sampling path.Validation
src/pyrecest/_backend/pytorch/random.pyandtests/backend/test_pytorch_random_backend.pychanged.py_compilelocally on reconstructed edited files.random.normalpath in a small local harness against Python bools, NumPy bool scalars, torch bool tensors, boolean tensor arrays, and mixed boolean object/list inputs.github.comto clone/install the repository.